openAds 2.3 custom tag discussion

Saturday 23 June 2007 12:58:57 am

Hi,

Can you use OpenAds to "rotate" banners on the Frontpage?

How would you approach that?

Thanks

Lukasz

Saturday 23 June 2007 1:40:08 am

OK thanks

I meant the main banner in class Frontpage so i will have to tweak the billboard.tpl i think

I will try this today and will share my feedback if this is ok with you/

Lukasz

Thursday 06 September 2007 5:19:51 am

Bonjour Laurent,

It looks like the template did'nt include the openAds files... view_local is the function I'm calling in openAds.

Did you check that you adjusted the path to openAds in content.ini.append.php ?
The template code gets the library path from there:

$defaultOpenAdsServer = $ini->variable( 'openads', 'DefaultOpenAdsServer' );
$defaultOpenAdsServerScript = $ini->variable( 'openads', 'DefaultOpenAdsServerScript' );

and then includes openAds this way:

define('MAX_PATH', $defaultOpenAdsServer);
@include_once(MAX_PATH.$defaultOpenAdsServerScript);

I hope this helps. I still have 2.3.35b, if you need to compare files, feel free to ask me.

Happy advertising,
Pascal

Thursday 06 September 2007 5:33:18 am

Pascal,

Much much better.
My content.ini was:

DefaultOpenAdsServer=/home/zoneindustrie/www/openads

But the directory isn't named "www" but "public_html" (haha!)

Now I can start playing with eZ and Openads.
It seems to be really powerfull and your extension should be include in the eZ regular release (my opinion).

Maybe I'll be back soon here for more ;)

Merci beaucoup.

Laurent

Thursday 06 September 2007 9:33:47 am

Hey Laurent,

how do you call openAds? Through an xml tag or through the template operator?

If you use the XML tag, all fields have to be filled in with plain values without any quotes or double quotes, in other words the dialog shows 1 2 3 and _self in the four form fields, for example.

If you use the template directly, I think i anways add the single quotes around the last argument, so maybe you should pass _self instead of '_self' as the argument ? I maybe did something wrong, I didn't use it from within a .tpl yet. the function openads_html may have to be written without adding quotes.

Let me know, and I'm going to correct that.

Pascal

Friday 07 September 2007 12:54:37 am

Hi Laurent,

yes, I believe the function does always add the single quotes to the output text, even if the quote was there before...
I added one line with a trim instruction.
Maybe you can give the following code a try and tell me if it corrects the problem. I would then update the library and post it again.
The code is placed in the lib folder:

   function openads_html( $zone_id, $campaign_id, $banner_id, $html_target )
   {

	if (!isset($phpAds_context)) {
		$phpAds_context = array();
	}
//-------------------------------------------------------------------------
	$html_target = trim( $html_target, "\ \"\'" );
//-------------------------------------------------------------------------
	$phpAds_raw = view_local('', $zone_id, $campaign_id , $banner_id, "'".$html_target."'", '', '0', $phpAds_context);
	return $phpAds_raw['html'];
   }

        

Let me know if this is a workaround.

Pascal

Friday 07 September 2007 5:03:10 am

Hi Laurent,

that's strange, because this is the place where the code gets generated. If you add nonsense characters there or a syntax error, do you see the consequence on your generated files?

Pascal

Friday 07 September 2007 5:41:46 am

Hi Laurent,

and if you would replace the
return $phpAds_raw['html'];
by
return "<b>hello</b>";

does your output reflect that change then? I mean if this is the case, I can't see how the redundant quotes still would remain, since we removed them just in this function.
Since I'm heavilly taken in another project right now, I can't find the time to look into your issue further for now, but I think this is the place to look at for sure.

Pascal

Friday 07 September 2007 7:24:34 am

of course! that's how PHP should work when returning a literal string!

Start from here:

	$html_target = trim( $html_target, "\ \"\'" );
	$phpAds_raw = view_local('', $zone_id, $campaign_id , $banner_id, "€".$html_target."€", '', '0', $phpAds_context);
	return $phpAds_raw['html'];

See what it generates, and according to that, add or replace the euro symbol with what's needed!

Pascal

Thursday 27 September 2007 5:02:41 am

Hi
I trie to use openads whit ezp,
Where can i find the rotate option in open ads ??