Forums / Developer / eZApprove2 - Cannot Reject changes

eZApprove2 - Cannot Reject changes

Author Message

Pratibha Gannavarapu

Wednesday 26 April 2006 9:20:25 pm

Hi
I have just installed eZApprove2 extension onto my EzPublish system and everything works fine. But the administrator is not able to reject the workflow. Approval is publishing the article well. And an editing by the admin also works good. But as compared to the standard workflow, a rejection by admin should push the article from 'My Pending Items' of the author to the 'My drafts'. But with this extension the article still lies in 'My Pending Items' even after rejecting it. Yes I did run cronjobs script :)
Any help?
Cheers
Pratibha

Kåre Køhler Høvik

Thursday 27 April 2006 1:26:25 am

Hi

Thanks for the bug report. I'll take a look at it, and see what's wrong.

Kåre Høvik

Georg Franz

Thursday 27 April 2006 4:44:40 am

Hi Kare,

great work!

I've a german translation of it which I can send you. (write me an email to [email protected])

Question:

If user 1 writes an comment which must be approved and user 2 approves it the $node->creator returns as content the user 2. Is this a bug or a feature? (I need it that the user 1 stays as creator). Any suggestion were to look in the code?

Best wishes,
Georg.

Best wishes,
Georg.

--
http://www.schicksal.com Horoskop website which uses eZ Publish since 2004

Kåre Køhler Høvik

Friday 28 April 2006 1:58:07 am

HI Georg

I'm not sure about the creator status, but I'll look into it as well. Thanks for reporting the bugs you find.

Has anyone tried the extension with 3.8 yet ?

Kåre Høvik

Murali K

Sunday 30 April 2006 6:21:15 am

When Denied, the item is not going to Drafts, it still remains under Pending Items.

I was trying to debug, and comparing the core WorkFlow and EzApprove2 workflow,

when a item is denied, following sql update statements were being executed.

Core Workflow (working as desired)

SQL:

UPDATE ezcollab_item_status SET is_active='0'
WHERE collaboration_id='18' AND user_id='14'


UPDATE ezcollab_item
SET type_identifier='ezapprove', creator_id='104', status='2',
    data_text1='', data_text2='', data_text3='', data_int1='121', data_int2='1',
    data_int3='2', data_float1='0.000000', data_float2='0.000000',
    data_float3='0.000000', created='1146401128', modified='1146401153'
WHERE  id='18'

EZApprove2 (not working as desired)

SQL:

UPDATE ezx_approve_status_user_link
SET approve_id='19', approve_status='2', approve_role='1', hash='',
    user_id='14', message_link_created='1', action='0'
WHERE  id='36'


UPDATE ezcollab_item
SET type_identifier='ezapprove2', creator_id='104', status='1',
    data_text1='', data_text2='', data_text3='', data_int1='123', data_int2='1',
    data_int3='0', data_float1='0.000000', data_float2='0.000000',
    data_float3='0.000000', created='1146402003', modified='1146402037'
WHERE  id='20'

I can see differences with status and a table not being updated.

can one tell me how to fix this?

Murali K

Sunday 30 April 2006 7:07:01 am

for debugging purposes, I have run this command on my database

UPDATE `ezcontentobject_version` SET `status` = '0' WHERE `id` = '571' LIMIT 1 ;

571 being the appropriate contentobject_id , this made the article to appear in Drafts..

The status value was "2" earlier.
With Standard Workflow, this value is being updated to 0 from cronjob.

however, for EZApprove2 Workflow, this value is not being updated to 0 when i run cronjob

I believe, this information is not going to cronjob??

.

Kåre Køhler Høvik

Monday 22 May 2006 7:56:30 am

Hi

I've fixed all the bugs mentioned here, except the setting version status to draft instead of rejected when the pending version is rejected.

German translation by Georg Franz will be added shortly in version 0.4.

Changelog: http://zev.ez.no/svn/extensions/ezapprove2/stable/0.3/extension/ezapprove2/doc/changelogs/CHANGELOG_0.2-0.3

Please test, and let me know how it goes.

Kåre Høvik

Brendan Pike

Monday 26 June 2006 12:46:20 am

I know this is slightly off topic but still thought it was the best place to post these queries.

I've been experimenting with ezapprove2 (and loving it) especially with staff who only have user_side siteaccess which so far seems to work fine.
But I've found a few problems on both user and admin side. I'm unsure if this is a bug or my mis-use, but I suspect a bug.

I want to write an alert if there are unread messages in a collaboration item but the unread_message_count is always the same as the message_count wether it has been viewed or not.

This could be effected by the fact that staff are not creators of the content only editors of it and that 1 object could be edited many times. Anyway I would like to hear others thoughts on this. Also noticed that after running update/common/scripts/cleanup.php collaboration now in collaboration notifications there are 2 instances of eZapprove2?

www.dbinformatics.com.au

We are always interested in hearing from experienced eZ PHP programmers and eZ template designers interested in contract work.